工作中的bug：for循环里面的创建对象和for循环外面创建对象

写这个博客的作用主要是给自己涨涨记性，以后像这种低级的错误最好不要再犯。

先看一下报错的日志：

2019-12-25 18:12:58.197 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : 进入更新后的InsPart
2019-12-25 18:12:58.197 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : mSql: insert into LPEdorItem ( EdorAcceptNo,EdorNo,EdorCode,PolicyNo,CustomerID,EdorState,ChangeMoney,BillMoney,EdorValiDate,Creator,Operator,MakeDate,MakeTime,ModifyDate,ModifyTime ) values ( 'MGU201912461201912358','EN20191225026','RE','MGU201912461','000000','10',1000.0,0.0,'2019-12-25','001','001','2019-12-25','18:12:41','2019-12-25','18:12:41' )
2019-12-25 18:12:58.246 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : mSql: delete from LPDebitNote where EdorNo='EN20191225026' and DebitNoteNo='DN0000000234'
2019-12-25 18:12:58.246 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : mSql: delete from LPDebitNote where EdorNo='EN20191225026' and DebitNoteNo='DN0000000234'
2019-12-25 18:12:58.372 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : 进入更新后的InsPart
2019-12-25 18:12:58.372 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : mSql: insert into LPDebitNote ( EdorNo,EdorCode,DebitNoteNo,DNTAmount,DebitNoteTitle,PaidAmnt,PaidCurr,PayDate,Status,VerificationAnt,DebitNoteMode,SubInsurerId,BankAccId,RiskCode,Creator,Operator,MakeDate,MakeTime,ModifyDate,ModifyTime ) values ( 'EN20191225026','RE','DN0000000234',1000.0,'22',1000.0,'01','2020-01-24','01',0.0,'04','ZCB-003-111','888888','X151','001','001','2019-12-25','18:12:41','2019-12-25','18:12:41' )
2019-12-25 18:12:58.372 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : 进入更新后的InsPart
2019-12-25 18:12:58.372 DEBUG 12332 --- [io-8080-exec-10] com.sinosoft.utility.SQLString           : mSql: insert into LPDebitNote ( EdorNo,EdorCode,DebitNoteNo,DNTAmount,DebitNoteTitle,PaidAmnt,PaidCurr,PayDate,Status,VerificationAnt,DebitNoteMode,SubInsurerId,BankAccId,RiskCode,Creator,Operator,MakeDate,MakeTime,ModifyDate,ModifyTime )

 values ( 'EN20191225026','RE','DN0000000234',1000.0,'22',1000.0,'01','2020-01-24','01',0.0,'04','ZCB-003-111','888888','X151','001','001','2019-12-25','18:12:41','2019-12-25','18:12:41' )

从报错日志上面看，这个错误已经很明显了，在执行向LPDebitNote表中插入数据的时候报主键冲突。从SQL语句中看，确实是这样的。

在看一下自己之前写的代码：

其实在最上面还有一行：LPDebitNoteSchema tLPDebitNoteSchema = new LPDebitNoteSchema();

 

 现在不难看出是因为给mlpdebitnotese集合中添加了两个相同的tLPDebitNoteSchema 对象，而且都是最后一次循环的那个对象。

改正之后的代码：

            SQLwithBindVariables sqlbv = new SQLwithBindVariables();
            String tSql = "SELECT * FROM LCDebitNoteDet WHERE PolicyNo='?PolicyNo?' ";
            sqlbv = new SQLwithBindVariables();
            sqlbv.sql(tSql);
            sqlbv.put("PolicyNo", mLPEdorAppSchema.getPolicyNo());
            tLCDebitNoteDetSet = tLCDebitNoteDetDB.executeQuery(sqlbv);
            //在LCDEBITNOTEDET表里面一个保单号能有多个DEBITNOTENO
            if(tLCDebitNoteDetSet!=null&&tLCDebitNoteDetSet.size()>0){
                for (int i = 1; i <=tLCDebitNoteDetSet.size() ; i++) {
                    LPDebitNoteSchema tLPDebitNoteSchema = new LPDebitNoteSchema();
                    SQLwithBindVariables sqlbv1 = new SQLwithBindVariables();
                    String tSql1 = "SELECT * FROM LCDebitNote WHERE DebitNoteNo='?DebitNoteNo?' ";
                    sqlbv1 = new SQLwithBindVariables();
                    sqlbv1.sql(tSql1);
                    sqlbv1.put("DebitNoteNo", tLCDebitNoteDetSet.get(i).getDebitNoteNo());
                    tLCDebitNoteSet = tLCDebitNoteDB.executeQuery(sqlbv1);
                    if (tLCDebitNoteSet != null && tLCDebitNoteSet.size() > 0) {
                        tLCDebitNoteSchema = tLCDebitNoteSet.get(1);
                        this.mReflections.transFields(tLPDebitNoteSchema, tLCDebitNoteSchema);
                        tLPDebitNoteSchema.setEdorNo(mEdorNo);
                        tLPDebitNoteSchema.setEdorCode(mLPEdorAppSchema.getEdorCode());
                        //   tLPDebitNoteSchema.setSelfPayOffState("02");签发的时候在进行状态的改变
                        // tLPDebitNoteSchema.setVerificationDate(mCurrentDate);
                        tLPDebitNoteSchema.setOperator(mG.Operator);
                        tLPDebitNoteSchema.setMakeDate(mCurrentDate);
                        tLPDebitNoteSchema.setMakeTime(mCurrentTime);
                        tLPDebitNoteSchema.setModifyDate(mCurrentDate);
                        tLPDebitNoteSchema.setModifyTime(mCurrentTime);
                        //mMap.put(tLPDebitNoteSchema,"DELETE&INSERT");
                    }
                    mLPDebitNoteSet.add(tLPDebitNoteSchema);
                }
                mMap.put(mLPDebitNoteSet,"DELETE&INSERT");
            }

这次就能完美运行了，不会报主键冲突了。