Code Review中应该关注的点

  1. Magic number/string
  1. If statement, you should always use single line or brackets
  1. Provide default value of Enum
  1. Difference between abstract class and interface
  1. Excess inheritance--the inheritance hierarchy is too deep
  1. Use string.Concat, string.Format, StringBuilder instead of +
  1. Const vs Readonly
  2. Break down large method into small methods
  1. Using nest class to hidden information is not necessary and hurts maintainability
  1. Do not use new keyword to hidden base class's method, please use polymorphism
  2. Static class may substitute singleton pattern for simplification
  3. Private members/property access are not necessary if not protecting; use auto properties instead
  4. Use IDisposable correctly to prevent resource leak for unmanaged resources.
  1. Tell browser the encoding you are using with meta tag
  2. Make sure browsers know you want to use edge rendering if you are building HTML5 websites
  3. Eliminating embedded javascript and style sheets to help improve caching of your code
  4. Use CDN so that browser caching can improve startup time for new users.
  5. Reduced round-trips with fewer CSS files means you are less likely to run into browser limits of CSS
  6. The less code inside a Razor file the better
  7. Creating cached objects inside per-request classes is not necessary and adds complexity
  8. Routing tables are still a valid way of doing routing for much your code
posted @ 2015-03-06 09:39  Fintech技术汇  阅读(346)  评论(0编辑  收藏  举报