如何提交代码到CEPH Repo。 顺便庆祝下,提交了第一个ceph pull request。实现了从0到1的突破
庆祝一下!经过社区老司机的带路,昨天提交了第一个ceph pull request。实现了从0到1的突破,希望再接再厉提交更多代码到社区,为社区发展贡献一点自己力量。
提交的第一个被社区fix的bug:http://tracker.ceph.com/issues/16654
提交的第一个 pull request : https://github.com/ceph/ceph/pull/12664, 等待被社区接受中……
顺便在这里总结一下提交Ceph代码的流程和规范。
正常流程 应该是tracker上面和审核员他们确定问题以后 再提交相应的代码,pull request 之前要在tracker开个bug单, 然后在request描述中把bug的链接也贴上,request的标题要以rgw: 开头。
如果要做低版本的backport 还需要等在主分支merge进去以后 才能做低版本的backport
如何 pull request ?
https://github.com/geeeeeeeeek/git-recipes/wiki/3.3-%E5%88%9B%E5%BB%BAPull-Request
commit规范:
Signed-off-by 要写在commit里面,不是pull request里。
例如:
rgw:when call the multiparts upload API TransferManager.upload() by …
…s3 java sdk , got the SignatureDoesNotMatch exception# http://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html URI-encode each parameter name and value according to the following rules: Do not URI-encode any of the unreserved characters that RFC 3986 defines: A-Z, a-z, 0-9, hyphen ( - ), underscore ( _ ), p Percent-encode all other characters with %XY, where X and Y are hexadecimal characters (0-9 and uppercase A-F). Signed-off-by: qiyu cn-qiyu@qq.com
pull request 标题:
要加前缀模块名,如"rgw:"
例如:
rgw:when call the multiparts upload API TransferManager.upload() by s3 java sdk , got the SignatureDoesNotMatch exception
pull request 内容:
request描述中把bug的链接也贴上
例如: fixbug: http://tracker.ceph.com/issues/18355