code review
package service;
import imp.UserDaoImp;
import![]()
java.io.IOException;
import![]()
java.io.PrintWriter;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import dao.UserDao;
import bean.User;
public class user_update extends HttpServlet {
/**
* Constructor of the object.
*/
public user_update() {
super();
}
/**
* Destruction of the servlet. <br>
*/
public void destroy() {
super.destroy(); // Just puts "destroy" string in log
// Put your code here
}
/**
* The doGet method of the servlet. <br>
*
* This method is called when a form has its tag value method equals to get.
*
* @param request the request send by the client to the server
* @param response the response send by the server to the client
* @throws ServletException if an error occurred
* @throws IOException if an error occurred
*/
public void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text![]()
ml");
PrintWriter out = response.getWriter();
out.println("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\">");
out.println("<HTML>");
out.println(" <HEAD><TITLE>A Servlet</TITLE></HEAD>");
out.println(" <BODY>");
out.print(" This is ");
out.print(this.getClass());
out.println(", using the GET method");
out.println(" </BODY>");
out.println("</HTML>");
out.flush();
out.close();
}
/**
* The doPost method of the servlet. <br>
*
* This method is called when a form has its tag value method equals to post.
*
* @param request the request send by the client to the server
* @param response the response send by the server to the client
* @throws ServletException if an error occurred
* @throws IOException if an error occurred
*/
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text![]()
ml");
request.setCharacterEncoding("utf-8");
response.setCharacterEncoding("utf-8");
String uid = request.getParameter("uid");
String uname = request.getParameter("uname");
String uclass = request.getParameter("uclass");
String upassword = request.getParameter("upassword");
User user = new User();
user.setuName(uname);
user.setuClass(uclass);
user.setuPassword(upassword);
UserDao userdao = new UserDaoImp();
int result = userdao.updateInfo(uid, user);
if (result > 0) {
PrintWriter out = response.getWriter();
out.print("<script type='text/javascript'>"
+ "alert('修改成功');window.location.href='../user_home.jsp';</script>");
out.flush();
out.close();
} else {
PrintWriter out = response.getWriter();
out.print("<script type='text/javascript'>"
+ "alert('修改失败');window.location.href='../user_update.jsp';</script>");
out.flush();
out.close();
}
}
/**
* Initialization of the servlet. <br>
*
* @throws ServletException if an error occurs
*/
public void init() throws ServletException {
// Put your code here
}
}
import imp.UserDaoImp;
import
import
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import dao.UserDao;
import bean.User;
public class user_update extends HttpServlet {
/**
* Constructor of the object.
*/
public user_update() {
super();
}
/**
* Destruction of the servlet. <br>
*/
public void destroy() {
super.destroy(); // Just puts "destroy" string in log
// Put your code here
}
/**
* The doGet method of the servlet. <br>
*
* This method is called when a form has its tag value method equals to get.
*
* @param request the request send by the client to the server
* @param response the response send by the server to the client
* @throws ServletException if an error occurred
* @throws IOException if an error occurred
*/
public void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text
PrintWriter out = response.getWriter();
out.println("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\">");
out.println("<HTML>");
out.println(" <HEAD><TITLE>A Servlet</TITLE></HEAD>");
out.println(" <BODY>");
out.print(" This is ");
out.print(this.getClass());
out.println(", using the GET method");
out.println(" </BODY>");
out.println("</HTML>");
out.flush();
out.close();
}
/**
* The doPost method of the servlet. <br>
*
* This method is called when a form has its tag value method equals to post.
*
* @param request the request send by the client to the server
* @param response the response send by the server to the client
* @throws ServletException if an error occurred
* @throws IOException if an error occurred
*/
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
response.setContentType("text
request.setCharacterEncoding("utf-8");
response.setCharacterEncoding("utf-8");
String uid = request.getParameter("uid");
String uname = request.getParameter("uname");
String uclass = request.getParameter("uclass");
String upassword = request.getParameter("upassword");
User user = new User();
user.setuName(uname);
user.setuClass(uclass);
user.setuPassword(upassword);
UserDao userdao = new UserDaoImp();
int result = userdao.updateInfo(uid, user);
if (result > 0) {
PrintWriter out = response.getWriter();
out.print("<script type='text/javascript'>"
+ "alert('修改成功');window.location.href='../user_home.jsp';</script>");
out.flush();
out.close();
} else {
PrintWriter out = response.getWriter();
out.print("<script type='text/javascript'>"
+ "alert('修改失败');window.location.href='../user_update.jsp';</script>");
out.flush();
out.close();
}
}
/**
* Initialization of the servlet. <br>
*
* @throws ServletException if an error occurs
*/
public void init() throws ServletException {
// Put your code here
}
}
1.这段代码有点长，并且有没有注释；
