代码的重构（Refactor-Extract）

1、vs中的代码重构快捷方式：Refactor-Extract；

选中两个需要重构的部分完整代码，右击，选中Refactoe-Extract-Extract Method；

该选中的代码会自动形成一个Execute()方法，自己修改方法名就OK啦。

2、下面说一下我的具体代码修改：这个是两个方法中执行了相同的INSERT语句，所以将它整合成一个方法；这样后续有修改或者改动时，会方便很多，也便于代码阅读。

//APP端（插入T_UserBookingTraining）
public int SubscribeIntentionMajor(int courseId, int shareUserId, string name, string phoneNum, string intentionMajor)
        {
            var type = 1;
            string tidSql = @"
IF EXISTS(
        SELECT   tcl.TrainingInstitutionId
        FROM    dbo.T_Course tc
        LEFT JOIN dbo.T_Class tcl ON tc.ClassId = tcl.Id
        WHERE  tc.Id = @cid)
        SELECT  tcl.TrainingInstitutionId
        FROM    dbo.T_Course tc
        LEFT JOIN dbo.T_Class tcl ON tc.ClassId = tcl.Id
        WHERE  tc.Id = @cid
ELSE
    SELECT 0";
            var tid = DbTopOnline.ExecuteScalar<int>(tidSql, new { cid = courseId });

            return InsertUserBookingTraining(shareUserId, name, phoneNum, intentionMajor, tid, type);
        }

//官网端（插入T_UserBookingTraining）
public int SubscribeIntentionMajorFromWebSite(string phoneNum, int tid)
        {
            var shareUserId = 0;
            var name = phoneNum;
            var intentionMajor = "来自官网的意向";
            var type = 2;
            return InsertUserBookingTraining(shareUserId, name, phoneNum, intentionMajor, tid, type);
        }

//重构出来的代码（主要执行INSERT操作）
private int InsertUserBookingTraining(int shareUserId, string name, string phoneNum, string intentionMajor, int tid, int type)
        {
            string userIdSql = @"
SELECT
    tu.Id 
FROM
    dbo.T_User tu 
WHERE
    tu.TrainingInstitutionId = @tid 
    AND Name = 'admin' 
    AND IsDel=0
    AND IsUsed=1";
            var userId = DbTopManager.ExecuteScalar<int>(userIdSql, new { tid });

            string sql = @";
IF EXISTS(SELECT * FROM T_UserBookingTraining WHERE Phone = @phoneNum AND TrainingInstitutionId = @tid )  --判断手机号
    BEGIN
            UPDATE   dbo.T_UserBookingTraining
            SET      Intention = @intentionMajor, UserName = @name
            WHERE    Phone = @phoneNum            
    END
ELSE
    BEGIN
        INSERT INTO dbo.T_UserBookingTraining
                    ( TrainingInstitutionId ,
                    TemplatId ,
                    SceneId ,
                    Type ,
                    UserId ,
                    ShareUserId ,
                    Phone ,
                    UserName ,
                    Intention ,
                    ProgressStatus ,
                    IsDel ,
                    IsUsed ,
                    CreateTime
                    )
            VALUES  ( @tid, -- TrainingInstitutionId - int
                    0 , -- TemplatId - int
                    0 , -- SceneId - int
                    @type , -- Type - tinyint
                    @userId , -- UserId - int
                    @uid, -- ShareUserId - int
                    @phoneNum, -- Phone - nchar(11)
                    @name, -- UserName - nvarchar(20)
                    @intentionMajor, -- Intention - nvarchar(60)
                    0 , -- ProgressStatus - tinyint
                    0 , -- IsDel - bit
                    1 , -- IsUsed - bit
                    GETDATE()  -- CreateTime - datetime
                    ) 
    END";
            return DbTopOnline.Execute(sql, new
            {
                userId,
                uid = shareUserId,
                name,
                phoneNum,
                intentionMajor,
                tid,
                type
            });
        }